Skip to content

Invalid file types still can be imported to the UF #1301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zebrum opened this issue Jun 28, 2017 · 5 comments
Closed

Invalid file types still can be imported to the UF #1301

zebrum opened this issue Jun 28, 2017 · 5 comments
Assignees
@nkartyshov
Labels
Bug P4: Low
Milestone
2.11

Comments

@zebrum
Copy link
Member

zebrum commented Jun 28, 2017

Should we allow only .txt files to be uploaded to user filter?
@vozersky
Copy link
Member

vozersky commented Jun 28, 2017 •
edited
Loading

STR

  1. Try to import image file as a filter list.

Expected result
Toast Error Message is shown

Actual result

Screenshot

image


Environment

Adguard 2.9.132 beta

@vozersky vozersky changed the title Upload only .txt files to user filter Invalid file types still can be imported to the UF Jun 28, 2017
@ameshkov ameshkov added this to the 2.10 milestone Jun 29, 2017
@ameshkov
Copy link
Member

@vozersky please attach a couple of invalid files you were using.

@ameshkov
Copy link
Member

@Revertron I added a check in the current version, but it didn't help.

@zebrum
Copy link
Member Author

zebrum commented Jun 29, 2017

Enable+HTTPS+Filtering+on+Android+Nougat.pdf
.png from archive: Screenshot_2017-06-28-19-55-32.png.zip

@ameshkov ameshkov modified the milestones: 2.11, 2.10 Sep 6, 2017
@nkartyshov nkartyshov assigned nkartyshov and unassigned Revertron Mar 1, 2018
@nkartyshov
Copy link
Contributor

done

@vozersky vozersky reopened this Mar 2, 2018
@vozersky vozersky closed this as completed May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkartyshov nkartyshov

Labels
Bug P4: Low
Projects
None yet
Milestone
2.11
Development

No branches or pull requests
5 participants
@Revertron @nkartyshov @ameshkov @vozersky @zebrum