AdGuard never finishes updating and hangs

[flammschrein]

Steps to reproduce

1. Install any Stable / Nightly release
2. Attempt to update to the latest nightly build / clean-install the latest Release or Nightly version
3. In-app update: AdGuard will enter endless loop on "Beginning update" screen. It will keep working but will never finish updating. The update installer itself will terminate after some time.
4. Clean install: AdGuard will throw an Error 1602. Installing will only be possible after manually removing all AG-associated temp files & registry entries.

Expected behavior

Update should run without issues

Actual behavior

Update hangs & crashes AdGuard / AdGuard is unable to install

Screenshot:

n/a

Customer ID & Logs

2024657

Your environment

• Environment name and version: Any Release/Nightly version of AdGuard
• Operating system and version: Windows 7

[COOLak]

I must add that sometimes in-app update completes after the first or the second reboot. But it's also not expected behavior and it doesn't alarm regarding the necessity of the reboot. And it works randomly.

[COOLak]

3. In-app update: AdGuard will enter endless loop on "Beginning update" screen before crashing to desktop

Sorry, it's not what I reported. It won't crash, it will keep working but will never finish updating. I just said that according to Task Manager the update installer closes after some time.

[flammschrein]

@COOLak thank you for the clarification, fixed!

[ameshkov]

Logs are in nextcloud

@northis since we're refactoring the installer anyway, I've assigned this bug to v7.2

According to the logs, there are multiple different issues, but the main seems to be this one:
Error 0x800704c7: Failed to launch elevated child process: C:\Temp\{A2514D85-6B10-47C3-937C-295A963740E5}\.be\setup1.exe

There might be an issue with the user's configuration, but anyway, it should be handled gracefully, and AG shouldn't be waiting until the user cancels the update manually.

[northis]

@akmLaVx @COOLak
About clean installation - it is strange, 1602 error (Failed to launch elevated child process) means that the user hasn't given admin rights on the UAC screen.
About in-app installation - there is one update in the logs, 25.07 from 7.1.2838 to 7.1.2868, and it was successful. There was another update 05.07, but there is no service logs for this date, only agent's, and according to the agent log, the update was successful too.

So it would be nice if we had logs for the endless loop on "Beginning update" moment

[ameshkov]

Regarding UAC -- we can do nothing about it.

Regarding "Starting update" issue, we should keep an eye on the setup process status.
If the setup is finished, but our process is still alive, we should consider update failed, and we should show an error message: Failed to update. Try to reinstall AdGuard.

[adbuker]

resolved in adguard-windows/pull-requests/578

[COOLak]

To be honest, nothing is resolved. I only can update AdGuard (even 7.3) after I freshly rebooted my PC. Should I open a browser and work in it for 5 minutes, then, even after closing the browser, AdGuard will be updating forever. Where should I send the logs next time?