Skip to content

Commit e9c09a2

Browse files
authored
[rb] Deprecate CDP methods on Firefox (#14763)
* Deprecate CDP for firefox * Make the deprecation message less generic
1 parent b1828bf commit e9c09a2

File tree

2 files changed

+14
-0
lines changed

2 files changed

+14
-0
lines changed

rb/lib/selenium/webdriver/common/driver_extensions/has_log_events.rb

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,13 @@ module HasLogEvents
5757
#
5858

5959
def on_log_event(kind, &block)
60+
if browser == :firefox
61+
WebDriver.logger.deprecate(
62+
'Driver#on_log_event on Firefox',
63+
'the script.add_console_message_handler or the script.add_javascript_error_handler methods',
64+
id: :on_log_event
65+
)
66+
end
6067
raise Error::WebDriverError, "Don't know how to handle #{kind} events" unless KINDS.include?(kind)
6168

6269
enabled = log_listeners[kind].any?

rb/lib/selenium/webdriver/common/driver_extensions/has_network_interception.rb

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,13 @@ module HasNetworkInterception
6060
#
6161

6262
def intercept(&)
63+
if browser == :firefox
64+
WebDriver.logger.deprecate(
65+
'Driver#intercept on Firefox',
66+
'the new bidi.network.add_intercept method',
67+
id: :intercept
68+
)
69+
end
6370
@interceptor ||= DevTools::NetworkInterceptor.new(devtools)
6471
@interceptor.intercept(&)
6572
end

0 commit comments

Comments
 (0)