Add build dependencies for Android Embedder

zoujunhua · zoujunhua · commit 85385856c7c1 · 2023-11-27T17:00:21.000+08:00
The build of embedded Android depends on the symbols of the 'icudtl.dat', as described in the change '0f32302bc17d39032393b6f287ad5055b89f9392' and '60968c892649301dadb15f4c2ce7329b04bf8827'. fixes flutter/flutter#97347
diff --git a/shell/platform/embedder/BUILD.gn b/shell/platform/embedder/BUILD.gn
@@ -177,6 +177,13 @@ template("embedder_source_set") {
       ]
     }
 
+    # For the Android, avoid dynamic lookups of the engine library's symbols need to depend on the 'icudtl.dat.S',
+    # which comes from the change '0f32302bc17d39032393b6f287ad5055b89f9392' and '60968c892649301dadb15f4c2ce7329b04bf8827'.
+    if (is_android) {
+      deps += [ "//flutter/shell/platform/android:icudtl_asm" ]
+      sources += [ "$root_build_dir/gen/flutter/shell/platform/android/third_party/icu/flutter/icudtl.dat.S" ]
+    }
+
     public_configs += [
       ":embedder_gpu_configuration_config",
       ":embedder_header_config",

Original file line number	Diff line number	Diff line change
`@@ -177,6 +177,13 @@ template("embedder_source_set") {`
`177`	`177`	`]`
`178`	`178`	`}`
`179`	`179`
	`180`	`+ # For the Android, avoid dynamic lookups of the engine library's symbols need to depend on the 'icudtl.dat.S',`
	`181`	`+ # which comes from the change '0f32302bc17d39032393b6f287ad5055b89f9392' and '60968c892649301dadb15f4c2ce7329b04bf8827'.`
	`182`	`+ if (is_android) {`
	`183`	`+ deps += [ "//flutter/shell/platform/android:icudtl_asm" ]`
	`184`	`+ sources += [ "$root_build_dir/gen/flutter/shell/platform/android/third_party/icu/flutter/icudtl.dat.S" ]`
	`185`	`+ }`
	`186`	`+`
`180`	`187`	`public_configs += [`
`181`	`188`	`":embedder_gpu_configuration_config",`
`182`	`189`	`":embedder_header_config",`