feat(spanner): support for Multiplexed Session Partitioned Ops #2252

alkatrivedi · 2025-03-20T10:03:44Z

This PR contains code changes to add support for multiplexed session support in Partitioned DML transactions.

This PR contains code changes to add support for option IsolationLevel at the client level and at the transaction level. supported methods are(RW and Blind Write): ``` - writeAtLeastOnce - runTransactionAsync - runTransaction - getTransaction - async getTransaction(from transaction runner class) ```

generated-files-bot · 2025-03-21T04:58:57Z

Warning: This pull request is touching the following templated files:

.kokoro/presubmit/node14/system-test-multiplexed-session.cfg - .kokoro files are templated and should be updated in synthtool
.kokoro/trampoline_v2.sh - .kokoro files are templated and should be updated in synthtool

sakthivelmanii · 2025-03-25T05:36:55Z

src/session-factory.ts

@@ -117,6 +126,12 @@ export class SessionFactory
    process.env.GOOGLE_CLOUD_SPANNER_MULTIPLEXED_SESSIONS === 'true'
      ? (this.isMultiplexed = true)
      : (this.isMultiplexed = false);
+    // set the isMultiplexedPartitionedOps property to true if multiplexed session is enabled for paritioned ops, otherwise set the property to false
+    process.env.GOOGLE_CLOUD_SPANNER_MULTIPLEXED_SESSIONS === 'true' &&


isMultiplexedPartitionOps = process.env.GOOGLE_CLOUD_SPANNER_MULTIPLEXED_SESSIONS === 'true' && process.env.GOOGLE_CLOUD_SPANNER_MULTIPLEXED_SESSIONS_PARTITIONED_OPS === 'true'

surbhigarg92 · 2025-03-26T09:46:07Z

src/session-factory.ts

+   * If multiplexed sessions are enabled for partitioned ops this methods delegates the request to `getSession()`, which will return
+   * either a multiplexed session or a regular session based on the configuration.
+   *
+   * If the multiplexed sessions are not enabled, a session is retrieved from the regular session pool.


Suggested change

* If the multiplexed sessions are not enabled, a session is retrieved from the regular session pool.

* If the multiplexed sessions are disabled, a session is retrieved from the regular session pool.

surbhigarg92 · 2025-03-26T09:46:36Z

src/session-factory.ts

@@ -143,6 +157,23 @@ export class SessionFactory
    );
  }

+  /**
+   * Retrieves a session for partitioned operations, selecting the appropriate session type
+   * based on whether multiplexed sessions are enabled for partitioned operations.


Suggested change

* based on whether multiplexed sessions are enabled for partitioned operations.

* based on whether multiplexed sessions are enabled.

surbhigarg92 · 2025-03-26T09:47:05Z

src/session-factory.ts

+   * Retrieves a session for partitioned operations, selecting the appropriate session type
+   * based on whether multiplexed sessions are enabled for partitioned operations.
+   *
+   * If multiplexed sessions are enabled for partitioned ops this methods delegates the request to `getSession()`, which will return


Suggested change

* If multiplexed sessions are enabled for partitioned ops this methods delegates the request to `getSession()`, which will return

* If multiplexed sessions are enabled for partitioned ops this methods delegates the request to `getSession()`, which returns

surbhigarg92 · 2025-03-26T09:48:35Z

src/session-factory.ts

@@ -165,7 +198,7 @@ export class SessionFactory
   * @throws {Error} If the session is invalid or cannot be released.
   */
  release(session: Session): void {
-    if (!this.isMultiplexed) {
+    if (!session.metadata.multiplexed) {


do we need optional check for "metadata" here ?

made it optional

surbhigarg92 · 2025-03-26T09:49:30Z

test/database.ts

-      });
+    muxEnabled.forEach(isMuxEnabled => {
+      describe(
+        'when GOOGLE_CLOUD_SPANNER_MULTIPLEXED_SESSIONS is ' +


Suggested change

'when GOOGLE_CLOUD_SPANNER_MULTIPLEXED_SESSIONS is ' +

'when GOOGLE_CLOUD_SPANNER_MULTIPLEXED_SESSIONS_PARTITIONED_OPS is ' +

surbhigarg92 · 2025-03-26T09:51:10Z

test/mockserver/mockspanner.ts

@@ -342,10 +342,14 @@ export class MockSpanner {
   * Creates a new session for the given database and adds it to the map of sessions of this server.
   * @param database The database to create the session for.
   */
-  private newSession(database: string): protobuf.Session {
+  private newSession(multiplexed: boolean, database: string): protobuf.Session {


add multiplexed: boolean as an optional parameter, with default value as false

surbhigarg92 · 2025-03-26T09:51:32Z

test/mockserver/mockspanner.ts

@@ -445,8 +449,9 @@ export class MockSpanner {
    this.simulateExecutionTime(this.batchCreateSessions.name)
      .then(() => {
        const sessions = new Array<protobuf.Session>();
+        const multiplexed = false;


This change should not be required once you make multiplexed as optional

yeah, updated. thanks for the suggestion!

* feat(spanner): support for Multiplexed Session Partitioned Ops * feat(spanner): add support for snapshot isolation (#2245) This PR contains code changes to add support for option IsolationLevel at the client level and at the transaction level. supported methods are(RW and Blind Write): ``` - writeAtLeastOnce - runTransactionAsync - runTransaction - getTransaction - async getTransaction(from transaction runner class) ``` * refactor * refactor

alkatrivedi requested review from a team as code owners March 20, 2025 10:03

product-auto-label bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/nodejs-spanner API. labels Mar 20, 2025

feat(spanner): support for Multiplexed Session Partitioned Ops

f163bb1

alkatrivedi force-pushed the mux-session-support-partitioned-ops branch from 6d5da0b to f163bb1 Compare March 20, 2025 10:47

alkatrivedi marked this pull request as draft March 20, 2025 10:50

alkatrivedi force-pushed the mux-session-support-partitioned-ops branch from d16e367 to 433a20a Compare March 20, 2025 13:23

Merge branch 'main' into mux-session-support-partitioned-ops

a91d2b9

alkatrivedi force-pushed the mux-session-support-partitioned-ops branch 2 times, most recently from 4803966 to 32ccb88 Compare March 20, 2025 13:56

refactor

0176e8f

alkatrivedi force-pushed the mux-session-support-partitioned-ops branch from 32ccb88 to 0176e8f Compare March 21, 2025 04:58

Merge branch 'main' into mux-session-support-partitioned-ops

8ed8dd0

alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 24, 2025

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 24, 2025

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 24, 2025

alkatrivedi force-pushed the mux-session-support-partitioned-ops branch 6 times, most recently from a0e46ff to 0683469 Compare March 24, 2025 13:57

alkatrivedi marked this pull request as ready for review March 24, 2025 13:58

sakthivelmanii reviewed Mar 25, 2025

View reviewed changes

alkatrivedi force-pushed the mux-session-support-partitioned-ops branch from 0683469 to 312504c Compare March 25, 2025 11:00

alkatrivedi added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 25, 2025

alkatrivedi added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 25, 2025

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 25, 2025

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 25, 2025

surbhigarg92 reviewed Mar 26, 2025

View reviewed changes

alkatrivedi force-pushed the mux-session-support-partitioned-ops branch from 312504c to 1014985 Compare March 26, 2025 11:13

alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 26, 2025

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 26, 2025

surbhigarg92 approved these changes Mar 26, 2025

View reviewed changes

refactor

d26c69a

alkatrivedi force-pushed the mux-session-support-partitioned-ops branch from 1014985 to d26c69a Compare March 26, 2025 13:45

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 26, 2025

alkatrivedi merged commit e7ce471 into main Mar 27, 2025
21 checks passed

alkatrivedi deleted the mux-session-support-partitioned-ops branch March 27, 2025 04:52

release-please bot mentioned this pull request Mar 27, 2025

chore(main): release 7.20.0 #2253

Merged

	* If the multiplexed sessions are not enabled, a session is retrieved from the regular session pool.
	* If the multiplexed sessions are disabled, a session is retrieved from the regular session pool.

	* based on whether multiplexed sessions are enabled for partitioned operations.
	* based on whether multiplexed sessions are enabled.

	* If multiplexed sessions are enabled for partitioned ops this methods delegates the request to `getSession()`, which will return
	* If multiplexed sessions are enabled for partitioned ops this methods delegates the request to `getSession()`, which returns

	'when GOOGLE_CLOUD_SPANNER_MULTIPLEXED_SESSIONS is ' +
	'when GOOGLE_CLOUD_SPANNER_MULTIPLEXED_SESSIONS_PARTITIONED_OPS is ' +

feat(spanner): support for Multiplexed Session Partitioned Ops #2252

feat(spanner): support for Multiplexed Session Partitioned Ops #2252

Uh oh!

Conversation

alkatrivedi commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

generated-files-bot bot commented Mar 21, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

alkatrivedi commented Mar 20, 2025 •

edited

Loading