Chore: introduce Fishery as object factory and yarn dev:msw #1023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adjust schema validation to make it optional - add test handlers for new alerts requests
- Also, invalidate cache for fetching fresh check alerts
- Instead of grouping by alert type, I'm displaying all alerts as separate ones - Grouping by type didn't allow to specify threshold for different percentiles
- since the alerts API is no longer in dev, I'm adding the mocks back to be able to test it - This should be improved by #850
- Also, adding loading and error states
- Add specific predefined alerts according to the check type in a single constants file - Display threshold units
a75b502 to
0b04626
Compare
The API is removing the id property for check alerts as they can be identified just by the name
ckbedwell
requested changes
Jan 23, 2025
src/module.ts
Outdated
Comment on lines
32
to
34
| if (process.env.NODE_ENV === 'development' && process.env.REACT_APP_MSW) { | ||
| setupWorker(...handlers).start(); | ||
| } |
There was a problem hiding this comment.
Just needs a small modification so it gets tree-shaken properly and doesn't affect the production bundle size:
- Move line 33 and associated imports to a file like
startServerWorker.ts:
import { setupWorker } from 'msw';
import { handlers } from 'test/handlers';
setupWorker(...handlers).start();
- change line 33 to:
await import(./startServiceWorker);
Then we don't include the additional 850kb overhead our mocks have 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #850
This PR introduces the following changes:
Fishery: Simplifies mocking data in tests, removing the need for hard-coded objects. It works alongside Faker to automatically generate dynamic test data for more flexible testing scenarios.
It defines factories for:
These factories are used to create fixtures in
src/test/fixtures/probes.ts,src/test/fixtures/checks.ts, andsrc/test/fixtures/checkAlerts.ts.Mocked API responses: Adds the ability to start the app with mocked API responses. To use this, run
yarn dev:msw. This runs a service worker that uses the same handlers as in test .Example of running the app using MSW mocked responses:
Screen.Recording.2024-12-20.at.15.44.15.mov