-
Notifications
You must be signed in to change notification settings - Fork 20
fix: remove canary config #1101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and most likely is super good.
I just don't know how to verify that it works as intended.
While testing the We could add some custom validation instead, but in the end I decided to remove this
The most important aspect is ensuring that the We will verify that the release process works as expected in the next release but we can be confident that no canary-related processes are being executed after these changes, as it's all been removed from the drone configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
...(Please work 😅🤞)
Add Pipeline Dependencies and Fix Configuration
Changes
Removed the
publish-canary
pipeline from.drone.yml
This pipeline was not being used. According to this,
prod-canary
is associated toprod-us-central-3
andprod-us-central-4
regions, but Synthetic Monitoring is not deployed there (see here for the list of regions where it's deployed). So removing it from drone made the most sense.This PR in the
deployment_tools
repo removes the explicit overrides in theprod-canary
wave file that we had before, so the versions will inherit from theprod
wave by default.Fixed configuration overlap by removing
prod-canary.libsonnet
update from production pipeline, ensuring the production pipeline only managesprod.libsonnet
Added Thomas (w1kman) as a reviewer for wave updates.
Updated drone signature as required after modifying this file.
Why