Skip to content

fix: remove canary config #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 4, 2025
Merged

fix: remove canary config #1101

merged 6 commits into from
Apr 4, 2025

Conversation

VikaCep
Copy link
Contributor

@VikaCep VikaCep commented Mar 27, 2025

Add Pipeline Dependencies and Fix Configuration

Changes

  1. Removed the publish-canary pipeline from .drone.yml
    This pipeline was not being used. According to this, prod-canary is associated to prod-us-central-3 and prod-us-central-4 regions, but Synthetic Monitoring is not deployed there (see here for the list of regions where it's deployed). So removing it from drone made the most sense.

    This PR in the deployment_tools repo removes the explicit overrides in the prod-canary wave file that we had before, so the versions will inherit from the prod wave by default.

  2. Fixed configuration overlap by removing prod-canary.libsonnet update from production pipeline, ensuring the production pipeline only manages prod.libsonnet

  3. Added Thomas (w1kman) as a reviewer for wave updates.

  4. Updated drone signature as required after modifying this file.

Why

  • Maintains clear separation of responsibilities between pipelines
  • Fixes the new failing check requiring single wave updates (see deployment_tools PR)

@VikaCep VikaCep self-assigned this Mar 27, 2025
@VikaCep VikaCep requested a review from a team as a code owner March 27, 2025 19:04
@VikaCep VikaCep requested review from w1kman and ckbedwell March 27, 2025 19:04
Copy link
Contributor

@w1kman w1kman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and most likely is super good.
I just don't know how to verify that it works as intended.

@VikaCep VikaCep changed the title feat: add pipeline dependencies and fix canary config fix: remove canary config Apr 3, 2025
@VikaCep
Copy link
Contributor Author

VikaCep commented Apr 3, 2025

While testing the staging promotion, I discovered that the depends_on clause wasn't working as expected. After some investigation, I found that it only works when pipelines are triggered by the same event and target.

We could add some custom validation instead, but in the end I decided to remove this depends_on clause since:

  1. It's not critical at this moment
  2. We're planning to migrate to GitHub Actions soon
  3. The main goal of this PR is to remove the unnecessary canary step from the deployment process

The most important aspect is ensuring that the production pipeline doesn't update the prod-canary.libsonnet file, which would cause the Single wave check to fail.

We will verify that the release process works as expected in the next release but we can be confident that no canary-related processes are being executed after these changes, as it's all been removed from the drone configuration.

@VikaCep VikaCep requested a review from w1kman April 3, 2025 19:57
Copy link
Contributor

@ckbedwell ckbedwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

...(Please work 😅🤞)

@VikaCep VikaCep merged commit 9dd6209 into main Apr 4, 2025
7 checks passed
@VikaCep VikaCep deleted the plugin-release-waves branch April 4, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants