fix: allow to send attachment without setting disposition

Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>

Author: SebastianKrupinski

lib/Provider/Command/MessageSend.php

@@ -60,8 +60,8 @@ public function perform(string $userId, string $serviceId, IMessage $message, ar
 		// validate that all attachments have a name, type, and contents
 		$entries = $message->getAttachments();
 		array_walk($entries, function ($entry) {
-			if (empty($entry->getName()) || empty($entry->getType()) || empty($entry->getContents())) {
-				throw new SendException('Invalid Attachment Parameter: MUST contain values for Name, Type and Contents');
+			if (empty($entry->getType()) || empty($entry->getContents())) {
+				throw new SendException('Invalid Attachment Parameter: MUST contain values for Type and Contents');
 			}
 		});
 		// retrieve user mail account details

lib/Service/TransmissionService.php

@@ -7,6 +7,7 @@
  */
 namespace OCA\Mail\Service;
 
+use Horde_Mime_Part;
 use OCA\Mail\Account;
 use OCA\Mail\Address;
 use OCA\Mail\AddressList;
@@ -73,20 +74,21 @@ public function getAttachments(LocalMessage $message): array {
 	 * @param array $attachment
 	 * @return \Horde_Mime_Part|null
 	 */
-	public function handleAttachment(Account $account, array $attachment): ?\Horde_Mime_Part {
+	public function handleAttachment(Account $account, array $attachment): ?Horde_Mime_Part {
 		if (!isset($attachment['id'])) {
 			$this->logger->warning('ignoring local attachment because its id is unknown');
 			return null;
 		}
 
 		try {
 			[$localAttachment, $file] = $this->attachmentService->getAttachment($account->getMailAccount()->getUserId(), (int)$attachment['id']);
-			$part = new \Horde_Mime_Part();
+			$part = new Horde_Mime_Part();
 			$part->setCharset('us-ascii');
-			$part->setDisposition('attachment');
-			$part->setName($localAttachment->getFileName());
+			if (!empty($localAttachment->getFileName())) {
+				$part->setDisposition('attachment');
+				$part->setName($localAttachment->getFileName());
+			}
 			$part->setContents($file->getContent());
-
 			/*
 			 * Horde_Mime_Part.setType takes the mimetype (e.g. text/calendar)
 			 * and discards additional parameters (like method=REQUEST).