This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove unused _TypeNone enum field. #14440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
reviewed
Dec 12, 2019
lib/ui/painting.dart
Outdated
| @@ -2633,6 +2633,7 @@ class ColorFilter { | |||
|
|
|||
| // The type of SkColorFilter class to create for Skia. | |||
| // These constants must be kept in sync with ColorFilterType in paint.cc. | |||
There was a problem hiding this comment.
This line is no longer true and should just be removed.
dnfield
reviewed
Dec 12, 2019
lib/ui/painting.dart
Outdated
Comment on lines
2636
to
2637
| // ignore:unused_field | ||
| static const int _TypeNone = 0; // null |
There was a problem hiding this comment.
Rather than adding an ignore, let's just remove the unused field.
We should also do the same in the web_ui painting.dart
There was a problem hiding this comment.
There is no _TypeNone in web_ui painting.dart as far as I can tell
There was a problem hiding this comment.
Rather than adding an ignore, let's just remove the unused field.
Done
There was a problem hiding this comment.
It's in lib/web_ui/lib/src/engine/color_filter.dart, line 118
There was a problem hiding this comment.
Ah, got you. Interestingly this is not picked up by analyzer as unused field.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2019
iskakaushik
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 13, 2019
* fb9dfe0 [fuchsia] Move async_get_default_dispatcher include to the header (flutter/engine#14351) * 3ebb7b4 Roll src/third_party/skia 75799967be60..3517aa7b14ad (3 commits) (flutter/engine#14345) * 2713225 Remove duplicate and outdated src/third_party/dart/tools/sdks entry from DEPS. (flutter/engine#14340) * 80d80ff Add ability to control dithering on Paint (flutter/engine#13868) * 8595361 Conditionally use offscreen root surface only when needed * 0a40f3d Assert that arc end caps on canvases with root surface transformations are drawn correctly. (flutter/engine#14359) * d698d96 Fix missing timeline event of flutter engine's startup time (flutter/engine#14319) * 9dc23b8 Fix missing API stream when record event in systrace (flutter/engine#14323) * 9e4c6ad Fix CGMutablePathRef memory leaks when the path is invalid. (flutter/engine#14275) * fc8cafb objcdoc fix for some ambiguity (flutter/engine#14367) * 9bafb3c [tests] Use distinct begin and end times (flutter/engine#14361) * 897ce34 Roll src/third_party/skia 3517aa7b14ad..826484f2631f (18 commits) (flutter/engine#14375) * 1ce85be [flutter_runner] Enable Skia tracing by default on Fuchsia (flutter/engine#13457) * a7b6ee5 Smart quote/dash configuration support in iOS (flutter/engine#13863) * 48ba39c Roll fuchsia/sdk/core/mac-amd64 from otkJA... to SlgE8... (flutter/engine#14407) * 0081e8c Remove unused _TypeNone enum field. (flutter/engine#14440) * d8edfea Roll src/third_party/dart d9fa37e85d5c..45db29709547 (48 commits) (flutter/engine#14453) * f650bca Refactoring text editing. Strategy pattern is used to handle different browser/operating system and a11y behavior. (flutter/engine#14131) * 4275b49 Fix type in build_fuchsia_artifacts (flutter/engine#14452) * 0c24f3d Roll src/third_party/skia 51b99659ed82..c514e7d9be6e (13 commits) (flutter/engine#14457) * ffbe2a4 [testing] Move test vsync waiters to their own TUs (flutter/engine#14456) * 181ad4e Use futures to images used for comparison with fixtures in embedder unit-tests. (flutter/engine#14465) * e0e0ac0 [testing] Make vsync waiters pluggable in shell_unittests (flutter/engine#14463)
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Mar 13, 2020
* Remove unused field * Similarly remove _TypeNone from web_ui
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_TypeNone is not used and that triggers hint in dart analyzer since dart 2.7.0