Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Fix svg stroke when style is not provided #24153

Merged
merged 14 commits into from
Feb 11, 2021
Merged

[web] Fix svg stroke when style is not provided #24153

merged 14 commits into from
Feb 11, 2021

Conversation

ferhatb
Copy link
Contributor

@ferhatb ferhatb commented Feb 3, 2021 •
edited
Loading

If Paint strokeWidth is set without setting style, html renderer now falls back to stroke to be consistent with skia.

This PR also fixes MaskFilter breaking on paths and drawLine canvas ops.

Related issue : flutter/flutter#74416

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the [engine presubmit flakes form] before re-triggering the failure.

@ferhatb ferhatb requested a review from mdebbar February 3, 2021 00:56
@chinmaygarde chinmaygarde added the platform-web Code specifically for the web engine label Feb 4, 2021
@ferhatb ferhatb merged commit 7e48c42 into flutter:master Feb 11, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 11, 2021
@engine-flutter-autoroll
7e48c42 [web] Fix svg stroke when style is not provided (flutter/engi…
06f3768 
…ne#24153)
@ferhatb ferhatb deleted the svgstroke branch February 11, 2021 17:41
zanderso pushed a commit to flutter/flutter that referenced this pull request Feb 12, 2021
@engine-flutter-autoroll
Roll Engine from cdc49c5 to b9ecd8a (2 revisions) (#75827)
b957144 
* 7e48c42 [web] Fix svg stroke when style is not provided (flutter/engine#24153)

* b9ecd8a Always set change type to cancel with `touchesCancelled` on iOS platform view (flutter/engine#24333)
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
@ferhatb @hjfreyer
[web] Fix svg stroke when style is not provided (flutter#24153)
4e4fb0a
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mdebbar mdebbar mdebbar approved these changes

Assignees
No one assigned
Labels
cla: yes platform-web Code specifically for the web engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ferhatb @mdebbar @chinmaygarde @googlebot