Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Use new cirrus secrets for engine. #25090

Merged
merged 1 commit into from
Mar 19, 2021
Merged

Use new cirrus secrets for engine. #25090

merged 1 commit into from
Mar 19, 2021

Conversation

godofredoc
Copy link
Contributor

Updates the cirrus engine secret in preparation to disable old service account keys.

Bug: flutter/flutter#77624

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

christopherfujino
christopherfujino approved these changes Mar 19, 2021
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@godofredoc godofredoc merged commit 6b621cb into flutter:master Mar 19, 2021
@godofredoc godofredoc deleted the use_new_secret branch March 19, 2021 04:38
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 19, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 19, 2021
@engine-flutter-autoroll
6b621cb Use new cirrus secrets for engine. (flutter/engine#25090)
a8fe504
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 20, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 20, 2021
@engine-flutter-autoroll
6b621cb Use new cirrus secrets for engine. (flutter/engine#25090)
287c1a1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 20, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 20, 2021
@engine-flutter-autoroll
6b621cb Use new cirrus secrets for engine. (flutter/engine#25090)
83d3d46
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 20, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 20, 2021
@engine-flutter-autoroll
6b621cb Use new cirrus secrets for engine. (flutter/engine#25090)
15fc171
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 20, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 20, 2021
@engine-flutter-autoroll
6b621cb Use new cirrus secrets for engine. (flutter/engine#25090)
9003163
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 22, 2021
@engine-flutter-autoroll
6b621cb Use new cirrus secrets for engine. (flutter/engine#25090)
777cada
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
@godofredoc @hjfreyer
Use new cirrus secrets for engine. (flutter#25090)
d96db32 
Bug: flutter/flutter#77624
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 22, 2021
@engine-flutter-autoroll
6b621cb Use new cirrus secrets for engine. (flutter/engine#25090)
11e48a8
chriscraws pushed a commit to chriscraws/engine that referenced this pull request Mar 23, 2021
@godofredoc @chriscraws
Use new cirrus secrets for engine. (flutter#25090)
69bc35a 
Bug: flutter/flutter#77624
cbracken
cbracken reviewed Apr 4, 2021
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed this before! Belated lgtm :)

duanqz pushed a commit to duanqz/engine that referenced this pull request Apr 16, 2021
@godofredoc @duanqz
Use new cirrus secrets for engine. (flutter#25090)
53f93e0 
Bug: flutter/flutter#77624
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cbracken cbracken cbracken left review comments

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@godofredoc @cbracken @christopherfujino @googlebot