This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[ios] [asan] Copy asan runtime dylib when built with "--asan" #25284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partially addresses: flutter/flutter#78433
chinmaygarde
approved these changes
Mar 29, 2021
jmagman
reviewed
Mar 29, 2021
| visibility = [ ":*" ] | ||
|
|
||
| _libclang_base_path = | ||
| "//buildtools/mac-x64/clang/lib/clang/13.0.0/lib/darwin/" |
There was a problem hiding this comment.
Is there any chance we can get this put in a path that doesn't contain the clang version, like //buildtools/mac-x64/clang/lib/clang/current/lib/darwin/? The tool will have to do some regexing for 13.0.0 otherwise.
There was a problem hiding this comment.
GN should fail at gn gen time if the file is not found after a toolchain update. I don't know if the toolchain contains a manifest about where certain resources are present.
There was a problem hiding this comment.
Oh I was looking in the wrong place in this file.
outputs = [ "$root_out_dir/$_dylib_name" ]
So that would be out/ios_debug_unopt/libclang_rt.asan_ios_dynamic.dylib. LGTM
jmagman
approved these changes
Mar 29, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 30, 2021
chandarrengoog
pushed a commit
to chandarrengoog/engine
that referenced
this pull request
Mar 30, 2021
duanqz
pushed a commit
to duanqz/engine
that referenced
this pull request
Apr 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses: flutter/flutter#78433