Support preferred locales for gen_l10n #47845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rami-a
approved these changes
Dec 27, 2019
| 'By default, the tool will generate the supported locales list in ' | ||
| 'alphabetical order. Use this flag if you would like to default to ' | ||
| 'a different locale. \n\n' | ||
| 'For example, pass in [\'en_US\'] of you would like your app to ' |
dev/tools/localization/gen_l10n.dart
Outdated
|
|
||
| if (preferredSupportedLocales != null) { | ||
| for (LocaleInfo preferredLocale in preferredSupportedLocales) { | ||
| if (!localeInfoList.contains(preferredLocale)) |
There was a problem hiding this comment.
I personally prefer adding the parentheses for all control statements, but I don't think we require that for flutter/flutter right?
There was a problem hiding this comment.
Yes, that's right. I actually prefer adding the parentheses for control statements as well because I feel that it doesn't cause as much confusion, but got used to doing it both ways. I added it back in for this particular case
…d list stays in alphabetical order
rami-a
approved these changes
Dec 30, 2019
This was referenced Dec 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the gen_l10n tool sorts supported locales by alphabetical order by default. This change adds the ability to add locales to the start of the list if a developer wants to prefer particular default locales over others.
Related Issues
Fixes #46244
Tests
I added the following tests:
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.