Broker connection secret #822
Conversation
…oo, this includes a refactor to reuse some helper methods for the triggers, sources and brokers. Fixed some tests and docs but still some to go in other commits
… to fix the unit tests + fixed source new parameters description yaml in config dir recovered vhost for conformance tests
…ster references + added sources to secret generator added secret reconciliation to source added secret informer
…urce reconciler code
…urce cluster reference validation + removed connection secret from source spec and updated codegen
…bbitmqResourcesConfig specs, refactored queue type and fixed tests to go along with it, now the source also have queue type + updated codegen
… by seting the predeclared flag
…g the conenction secret + fixed sample, still some work to do on the docs
…tion in the broker and source
… and a connection secret set
…ace sample and fixed sample file names, readmes and other nits
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gabo1208 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
26e1213 to
805f464
Compare
Codecov Report
@@ Coverage Diff @@
## main #822 +/- ##
==========================================
- Coverage 71.88% 71.86% -0.03%
==========================================
Files 39 40 +1
Lines 2600 2598 -2
==========================================
- Hits 1869 1867 -2
+ Misses 665 664 -1
- Partials 66 67 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Thanks for the changes. The extra e2e tests to validate external clusters is useful. I don't know if we want to maintain so many different sample directories. If it's a straightforward configuration or setting, documenting it in the main docs might be sufficient.
|
/lgtm we'll do the consolidation of the docs in a follow-up |
Changes
/kind enhancement
Fixes #819
Fixes #829
Release Note