Fixes #218254 #219312
Merged
Fixes #218254 #219312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mjbvz could you please check and review this change 🙂. I'm a bit new to this code repo and would appreciate your feedback. |
|
Fixes #218254 |
Closed
|
@mjbvz could you please take a look at this when you have a moment 🙂? Thank you! 🙂 |
fc3f18b to
85d6dc3
Compare
mjbvz
reviewed
Jul 8, 2024
| @@ -506,6 +505,10 @@ export class WebviewElement extends Disposable implements IWebview, WebviewFindD | |||
|
|
|||
| this._messagePort = e.ports[0]; | |||
| this._messagePort.onmessage = (e) => { | |||
| if (e.data.channel === 'did-context-menu') { | |||
d0ae5a2 to
155513e
Compare
onDidShowContextMenu fires for every webview even though only one webview has the context menu visible, hence removed the onDidShow listener, sending the set-context-menu-visible event to the html on did-context-menu event so that the context-menu-visible class gets applied only to the webview that actually has the context menu visible
Tyriar
approved these changes
Jul 8, 2024
rzhao271
approved these changes
Jul 8, 2024
aaronchucarroll
pushed a commit
to aaronchucarroll/vscode
that referenced
this pull request
Jul 10, 2024
onDidShowContextMenu fires for every webview even though only one webview has the context menu visible, hence removed the onDidShow listener, sending the set-context-menu-visible event to the html on did-context-menu event so that the context-menu-visible class gets applied only to the webview that actually has the context menu visible
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #218254
onDidShowContextMenu fires for every webview even though only one webview has the context menu visible, hence removed the onDidShow listener, sending the set-context-menu-visible event to the html on did-context-menu event so that the context-menu-visible class gets applied only to the webview that actually has the context menu visible