Associate sample interval with source #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakuco
reviewed
Apr 8, 2024
| @@ -1041,7 +1049,7 @@ <h3>Supporting algorithms</h3> | |||
| Let |record:PressureRecord| be |observer|.{{PressureObserver/[[LastRecordMap]]}}[|source|]. | |||
| </li> | |||
| <li> | |||
| Let |sampleInterval| be |observer|.{{PressureObserver/[[SampleInterval]]}}. | |||
| Let |sampleInterval| be |observer|.{{PressureObserver/[[SampleIntervalMap]]}}[|source|]. | |||
There was a problem hiding this comment.
Do you need to check if this key exists just like you do for [[LastRecordMap]]? I don't fully remember if there can be a condition where the corresponding entry is removed before this algorithm is called.
There was a problem hiding this comment.
as far as I can see, no. It always exists as there is a default value and we only remove it as we stop observing the source.
rakuco
reviewed
Apr 8, 2024
|
This is just an internal change? doesn't modify yet the way the user enter the |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sample interval should be per source, and updated when observe() is called with the same source again.
This is consistent with what PerformanceObserver does
Preview | Diff